Skip to content

Raise NotUniqueError in Document.update() on pymongo.errors.DuplicateKeyError #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2014
Merged

Raise NotUniqueError in Document.update() on pymongo.errors.DuplicateKeyError #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
803cadd
Raise NotUniqueError in Document.update() on pymongo.errors.Duplicate…
KonishchevDmitry Apr 9, 2014
b45a601
Test raising NotUniqueError by Document.update()
KonishchevDmitry Apr 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mongoengine/queryset/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,8 @@ def update(self, upsert=False, multi=True, write_concern=None,
return result
elif result:
return result['n']
except pymongo.errors.DuplicateKeyError, err:
raise NotUniqueError(u'Update failed (%s)' % unicode(err))
except pymongo.errors.OperationFailure, err:
if unicode(err) == u'multi not coded yet':
message = u'update() method requires MongoDB 1.1.3+'
Expand Down
12 changes: 11 additions & 1 deletion tests/document/instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

from mongoengine import *
from mongoengine.errors import (NotRegistered, InvalidDocumentError,
InvalidQueryError)
InvalidQueryError, NotUniqueError)
from mongoengine.queryset import NULLIFY, Q
from mongoengine.connection import get_db
from mongoengine.base import get_document
Expand Down Expand Up @@ -990,6 +990,16 @@ def update_no_op_raises():

self.assertRaises(InvalidQueryError, update_no_op_raises)

def test_update_unique_field(self):
class Doc(Document):
name = StringField(unique=True)

doc1 = Doc(name="first").save()
doc2 = Doc(name="second").save()

self.assertRaises(NotUniqueError, lambda:
doc2.update(set__name=doc1.name))

def test_embedded_update(self):
"""
Test update on `EmbeddedDocumentField` fields
Expand Down