Skip to content

ListField of embedded docs doesn't set the _instance attribute when iterating over it #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2015
Merged

ListField of embedded docs doesn't set the _instance attribute when iterating over it #920

merged 1 commit into from
Apr 2, 2015

Conversation

@DavidBord
Copy link
Contributor

@DavidBord DavidBord commented Mar 30, 2015

fixes #914

Review on Reviewable

@landscape-bot
Copy link

landscape-bot commented Mar 30, 2015

Code Health
Repository health increased by 0.15% when pulling 854ab98 on DavidBord:fix-914 into cbd2a44 on MongoEngine:master.

@coveralls
Copy link

coveralls commented Mar 30, 2015

Coverage Status

Changes Unknown when pulling 854ab98 on DavidBord:fix-914 into * on MongoEngine:master*.

6 similar comments
@coveralls
Copy link

coveralls commented Mar 30, 2015

Coverage Status

Changes Unknown when pulling 854ab98 on DavidBord:fix-914 into * on MongoEngine:master*.

@coveralls
Copy link

coveralls commented Mar 30, 2015

Coverage Status

Changes Unknown when pulling 854ab98 on DavidBord:fix-914 into * on MongoEngine:master*.

@coveralls
Copy link

coveralls commented Mar 30, 2015

Coverage Status

Changes Unknown when pulling 854ab98 on DavidBord:fix-914 into * on MongoEngine:master*.

@coveralls
Copy link

coveralls commented Mar 30, 2015

Coverage Status

Changes Unknown when pulling 854ab98 on DavidBord:fix-914 into * on MongoEngine:master*.

@coveralls
Copy link

coveralls commented Mar 30, 2015

Coverage Status

Changes Unknown when pulling 854ab98 on DavidBord:fix-914 into * on MongoEngine:master*.

@coveralls
Copy link

coveralls commented Mar 30, 2015

Coverage Status

Changes Unknown when pulling 854ab98 on DavidBord:fix-914 into * on MongoEngine:master*.

@DavidBord DavidBord changed the title fix-#914: ListField of embedded docs doesn't set the _instance attribute... ListField of embedded docs doesn't set the _instance attribute when iterating over it Apr 1, 2015
@landscape-bot
Copy link

landscape-bot commented Apr 2, 2015

Code Health
Code quality remained the same when pulling bb77838 on DavidBord:fix-914 into 1001f1b on MongoEngine:master.

@coveralls
Copy link

coveralls commented Apr 2, 2015

Coverage Status

Coverage decreased (-0.33%) to 73.08% when pulling bb77838 on DavidBord:fix-914 into 1001f1b on MongoEngine:master.

DavidBord added a commit that referenced this pull request Apr 2, 2015
@DavidBord
Merge pull request #920 from DavidBord/fix-914
a092910 
ListField of embedded docs doesn't set the _instance attribute when iterating over it
@DavidBord DavidBord merged commit a092910 into MongoEngine:master Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ListField of embedded docs doesn't set the _instance attribute when iterating over it

4 participants

@DavidBord @landscape-bot @coveralls @yograterol