Skip to content

Getting user by USERNAME_FIELD #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Getting user by USERNAME_FIELD #969

wants to merge 1 commit into from

Conversation

@cmaring
Copy link

@cmaring cmaring commented Apr 22, 2015

Review on Reviewable

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 33f55ff on cmaring:master into 7e1a5ce on MongoEngine:master.

@MRigal
Copy link
Member

MRigal commented Apr 22, 2015

Your PR makes sense, but please add small test case, where you define a specific USERNAME_FIELD

@mmellison
Copy link
Contributor

Label and close as part of Django split. See #973.

@mmellison mmellison closed this Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cmaring @landscape-bot @MRigal @mmellison