Merge branch 'development' into sentry-crash-reporting

Author: Excellencedev

src/Host.cpp

@@ -3347,6 +3347,66 @@ bool Host::setClickthrough(const QString& name, bool clickthrough)
     return false;
 }
 
+bool Host::setLabelStyleSheet(const QString& name, const QString& styleSheet)
+{
+    if (!mpConsole) {
+        return false;
+    }
+
+    auto pL = mpConsole->mLabelMap.value(name);
+    if (pL) {
+        pL->setStyleSheet(styleSheet);
+        return true;
+    }
+
+    return false;
+}
+
+bool Host::setLinkStyle(const QString& name, const QString& linkColor, const QString& linkVisitedColor, bool underline)
+{
+    if (!mpConsole) {
+        return false;
+    }
+
+    auto pL = mpConsole->mLabelMap.value(name);
+    if (pL) {
+        pL->setLinkStyle(linkColor, linkVisitedColor, underline);
+        return true;
+    }
+
+    return false;
+}
+
+bool Host::resetLinkStyle(const QString& name)
+{
+    if (!mpConsole) {
+        return false;
+    }
+
+    auto pL = mpConsole->mLabelMap.value(name);
+    if (pL) {
+        pL->resetLinkStyle();
+        return true;
+    }
+
+    return false;
+}
+
+bool Host::clearVisitedLinks(const QString& name)
+{
+    if (!mpConsole) {
+        return false;
+    }
+
+    auto pL = mpConsole->mLabelMap.value(name);
+    if (pL) {
+        pL->clearVisitedLinks();
+        return true;
+    }
+
+    return false;
+}
+
 void Host::hideMudletsVariables()
 {
     auto varUnit = getLuaInterface()->getVarUnit();
@@ -4004,9 +4064,12 @@ bool Host::setBackgroundColor(const QString& name, int r, int g, int b, int alph
         QString styleSheet = pL->styleSheet();
         QString newColor = QString("background-color: rgba(%1, %2, %3, %4);").arg(r).arg(g).arg(b).arg(alpha);
         if (styleSheet.contains(qsl("background-color"))) {
-            QRegularExpression re("background-color: .*;");
+            QRegularExpression re("background-color:[^;]*;");
             styleSheet.replace(re, newColor);
         } else {
+            if (!styleSheet.isEmpty() && !styleSheet.endsWith('\n')) {
+                styleSheet.append('\n');
+            }
             styleSheet.append(newColor);
         }
 
@@ -4414,6 +4477,9 @@ void Host::setFocusOnHostActiveCommandLine()
 
 void Host::recordActiveCommandLine(TCommandLine* pCommandLine)
 {
+    if (!pCommandLine) {
+        return;
+    }
     mpLastCommandLineUsed.removeAll(QPointer<TCommandLine>(pCommandLine));
     mpLastCommandLineUsed.push(QPointer<TCommandLine>(pCommandLine));
 }

src/Host.h

@@ -379,6 +379,10 @@ class Host : public QObject
     std::pair<bool, QString> createScrollBox(const QString& windowname, const QString& name, int x, int y, int width, int height) const;
     std::pair<bool, QString> createLabel(const QString& windowname, const QString& name, int x, int y, int width, int height, bool fillBg, bool clickthrough);
     bool setClickthrough(const QString& name, bool clickthrough);
+    bool setLabelStyleSheet(const QString& name, const QString& styleSheet);
+    bool setLinkStyle(const QString& name, const QString& linkColor, const QString& linkVisitedColor, bool underline);
+    bool resetLinkStyle(const QString& name);
+    bool clearVisitedLinks(const QString& name);
     void hideMudletsVariables();
     bool createBuffer(const QString& name);
     QSize calcFontSize(const QString& windowName);

src/TLabel.cpp

@@ -27,6 +27,11 @@
 #include "TDockWidget.h"
 #include "mudlet.h"
 
+#include <QDesktopServices>
+#include <QRegularExpression>
+#include <QTextCursor>
+#include <QTimer>
+#include <QUrl>
 #include <QtEvents>
 
 
@@ -37,6 +42,12 @@ TLabel::TLabel(Host* pH, const QString& name, QWidget* pW)
 {
     setMouseTracking(true);
     setObjectName(qsl("label_%1_%2").arg(pH->getName(), mName));
+
+    setTextFormat(Qt::RichText);
+    setTextInteractionFlags(Qt::TextBrowserInteraction);
+    setOpenExternalLinks(false);
+
+    connect(this, &QLabel::linkActivated, this, &TLabel::slot_linkActivated);
 }
 
 TLabel::~TLabel()
@@ -47,6 +58,77 @@ TLabel::~TLabel()
     }
 }
 
+void TLabel::setText(const QString& text)
+{
+    // If we have link styling configured and the text contains HTML links,
+    // we need to inject inline styles because QTextDocument doesn't use
+    // widget stylesheets or QPalette for link colors when a stylesheet exists
+    if ((!mLinkColor.isEmpty() || !mLinkVisitedColor.isEmpty()) && text.contains(qsl("<a "))) {
+        QString styledText = text;
+
+        // Replace all <a href="..."> tags with <a href="..." style="...">
+        // Note: This regex is intentionally strict (lowercase, href first, no spacing around =)
+        // because Mudlet's HTML generation (via echo(), setLabelText(), etc.) consistently
+        // uses this format. User-provided HTML outside this pattern will still render as
+        // clickable links (Qt handles that), but won't receive custom styling.
+        QRegularExpression anchorRegex(qsl("<a\\s+href=([\"'][^\"']*[\"'])([^>]*)>"));
+        QRegularExpressionMatchIterator it = anchorRegex.globalMatch(styledText);
+
+        // Process matches in reverse order to avoid offset issues
+        QList<QRegularExpressionMatch> matches;
+        while (it.hasNext()) {
+            matches.prepend(it.next());
+        }
+
+        for (const auto& match : matches) {
+            QString fullMatch = match.captured(0);
+            QString hrefPart = match.captured(1);  // The href="..." part
+            QString otherAttrs = match.captured(2); // Other attributes
+
+            // Extract the actual URL from hrefPart (remove quotes)
+            QString url = hrefPart;
+            url.remove(0, 1); // Remove opening quote
+            url.chop(1);      // Remove closing quote
+
+            bool isVisited = mVisitedLinks.contains(url);
+
+            QString linkStyle;
+            if (isVisited && !mLinkVisitedColor.isEmpty()) {
+                linkStyle += qsl("color: %1; ").arg(mLinkVisitedColor);
+            } else if (!mLinkColor.isEmpty()) {
+                linkStyle += qsl("color: %1; ").arg(mLinkColor);
+            }
+
+            if (!mLinkUnderline) {
+                linkStyle += qsl("text-decoration: none; ");
+            }
+
+            if (!linkStyle.isEmpty()) {
+                linkStyle = linkStyle.trimmed();
+
+                QString replacement;
+                if (otherAttrs.contains(qsl("style="))) {
+                    // Already has a style attribute - merge our styles
+                    // This is complex, so for now just prepend our styles
+                    replacement = qsl("<a href=%1 style=\"%2\"").arg(hrefPart, linkStyle);
+                    // Intentionally overwrites any existing style attribute rather than merging
+                    // to keep implementation simple for the common case (labels without pre-existing inline styles)
+                    otherAttrs.remove(QRegularExpression(qsl("style=([\"'][^\"']*[\"'])")));
+                    replacement += otherAttrs + qsl(">");
+                } else {
+                    replacement = qsl("<a href=%1 style=\"%2\"%3>").arg(hrefPart, linkStyle, otherAttrs);
+                }
+
+                styledText.replace(match.capturedStart(), match.capturedLength(), replacement);
+            }
+        }
+
+        QLabel::setText(styledText);
+    } else {
+        QLabel::setText(text);
+    }
+}
+
 void TLabel::setClick(const int func)
 {
     releaseFunc(mClickFunction, func);
@@ -91,6 +173,15 @@ void TLabel::setLeave(const int func)
 
 void TLabel::mousePressEvent(QMouseEvent* event)
 {
+    // If the label has rich text with potential hyperlinks, let QLabel handle the event first
+    // QLabel will emit linkActivated if a link was clicked
+    if (!text().isEmpty() && textFormat() == Qt::RichText && text().contains(qsl("<a "))) {
+        QLabel::mousePressEvent(event);
+        // If QLabel didn't accept the event, then it wasn't a link click
+        if (event->isAccepted()) {
+            return;
+        }
+    }
 
     if (mpHost && mClickFunction) {
         mpHost->getLuaInterpreter()->callLabelCallbackEvent(mClickFunction, event);
@@ -115,6 +206,15 @@ void TLabel::mouseDoubleClickEvent(QMouseEvent* event)
 
 void TLabel::mouseReleaseEvent(QMouseEvent* event)
 {
+    // If the label has rich text with potential hyperlinks, let QLabel handle the event first
+    if (!text().isEmpty() && textFormat() == Qt::RichText && text().contains(qsl("<a "))) {
+        QLabel::mouseReleaseEvent(event);
+        // If QLabel accepted the event, it was handling a link click
+        if (event->isAccepted()) {
+            return;
+        }
+    }
+
     auto labelParent = qobject_cast<TConsole*>(parent());
     if (labelParent && labelParent->mpDockWidget && labelParent->mpDockWidget->isFloating()) {
         // move focus back to the active console / command line:
@@ -189,4 +289,129 @@ void TLabel::releaseFunc(const int existingFunction, const int newFunction)
 void TLabel::setClickThrough(bool clickthrough)
 {
     setAttribute(Qt::WA_TransparentForMouseEvents, clickthrough);
+
+    // If clickthrough is enabled, text interaction (including hyperlinks) won't work
+    // So we need to disable text interaction when clickthrough is on
+    if (clickthrough) {
+        setTextInteractionFlags(Qt::NoTextInteraction);
+    } else {
+        // Re-enable text interaction for clickable hyperlinks
+        setTextInteractionFlags(Qt::TextBrowserInteraction);
+    }
+}
+
+void TLabel::setLinkStyle(const QString& linkColor, const QString& linkVisitedColor, bool underline)
+{
+    mLinkColor = linkColor;
+    mLinkVisitedColor = linkVisitedColor;
+    mLinkUnderline = underline;
+
+    // Set QPalette as a fallback (works if no stylesheet is set on the widget)
+    QPalette palette = this->palette();
+
+    if (!linkColor.isEmpty()) {
+        QColor color(linkColor);
+        palette.setColor(QPalette::Active, QPalette::Link, color);
+        palette.setColor(QPalette::Inactive, QPalette::Link, color);
+    }
+
+    if (!linkVisitedColor.isEmpty()) {
+        QColor color(linkVisitedColor);
+        palette.setColor(QPalette::Active, QPalette::LinkVisited, color);
+        palette.setColor(QPalette::Inactive, QPalette::LinkVisited, color);
+    }
+
+    setPalette(palette);
+
+    // Note: Widget stylesheets don't affect QTextDocument rendering
+    // Link colors are applied via inline styles in setText()
+
+    // Force update to re-render with new styles
+    update();
+}
+
+void TLabel::resetLinkStyle()
+{
+    setPalette(QPalette());
+
+    mLinkColor.clear();
+    mLinkVisitedColor.clear();
+    mLinkUnderline = true;
+
+    // Force update to re-render with new styles
+    update();
+}
+
+void TLabel::clearVisitedLinks()
+{
+    mVisitedLinks.clear();
+
+    QString currentText = text();
+    if (!currentText.isEmpty() && currentText.contains(qsl("<a "))) {
+        setText(currentText);
+    }
+}
+
+void TLabel::slot_linkActivated(const QString& link)
+{
+    if (!mpHost) {
+        return;
+    }
+
+    if (!mLinkVisitedColor.isEmpty()) {
+        mVisitedLinks.insert(link);
+
+        // Refresh the label to update link colors
+        // We need to re-apply the current text to trigger the styling update
+        QString currentText = text();
+        if (!currentText.isEmpty() && currentText.contains(qsl("<a "))) {
+            setText(currentText);
+        }
+    }
+
+    // Check for custom schemes by looking for the colon separator
+    const int colonPos = link.indexOf(':');
+
+    if (colonPos > 0) {
+        const QString scheme = link.left(colonPos).toLower(); // RFC 3986: schemes are case-insensitive
+        const QString payload = link.mid(colonPos + 1); // Everything after the colon
+
+        // Handle custom Mudlet URL schemes for Lua commands
+        if (scheme == qsl("send")) {
+            // send: scheme - send the command to the MUD immediately
+            mpHost->send(payload);
+            return;
+        }
+
+        if (scheme == qsl("prompt")) {
+            // prompt: scheme - put text in command line and wait for user to press enter
+            if (mpHost->mpConsole && mpHost->mpConsole->mpCommandLine) {
+                QPointer<TCommandLine> commandLine = mpHost->mpConsole->mpCommandLine;
+                commandLine->setPlainText(payload);
+                QTextCursor cursor = commandLine->textCursor();
+                cursor.movePosition(QTextCursor::End);
+                commandLine->setTextCursor(cursor);
+                // Defer the focus operation to avoid issues with QPointer manipulation
+                // during the signal handler execution
+                QTimer::singleShot(0, commandLine.data(), [commandLine]() {
+                    if (commandLine) {
+                        commandLine->setFocus();
+                    }
+                });
+            }
+            return;
+        }
+
+        if (scheme == qsl("http") || scheme == qsl("https")) {
+            QDesktopServices::openUrl(QUrl(link));
+            return;
+        }
+
+        // Unknown scheme - ignore safely to prevent unintended Lua execution
+        // Only links without a scheme should be treated as Lua code
+        return;
+    }
+
+    // No scheme - treat as Lua code to execute
+    mpHost->mLuaInterpreter.compileAndExecuteScript(link);
 }