TensorAlgebra cleanup and optimization #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #1 some operations were added in tensor algebra. In this PR, duplicated functions have been removed and optimized.
Additionally, some tests are stronger. For instance, the previous tests were unable to track some operations, given that
norm(⊗₁₂³⁴) == norm(⊗₁₃²⁴) == norm(⊗₁₄²³)ornorm(⊗₁²³) == norm(⊗₁₂³) == norm(⊗₁₃²). The current tests take advantage of the integer multiplications, which are easy to track component by component.On the performance side, the substitution of component by component multiplications by generated functions, allow to speedup operations about x30. In the case of contractions in R² space:
The corresponding changes have been applied to the viscous model.