🚧 ensure a valid python identifier for report_manger.py streamlit file #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save subsection are also referenced as Page instances, therefore they need a valid Python variable name. This would not be catched at build time, but only when report is being run.
sayalaruano
approved these changes
Apr 11, 2025
Collaborator
sayalaruano
left a comment
sayalaruano
left a comment
There was a problem hiding this comment.
Good catch. Also, nice to add pytest, maybe it's applicable in other parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save subsection are also referenced as Page instances, therefore they need a valid Python variable name.
This would not be catched at build time, but only when report is being run.