Skip to content

Conversation

@enryH
Copy link
Collaborator

@enryH enryH commented Apr 28, 2025

@enryH enryH linked an issue Apr 28, 2025 that may be closed by this pull request
@enryH enryH marked this pull request as ready for review April 29, 2025 08:23
@enryH enryH requested review from Copilot and sayalaruano April 29, 2025 14:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a shutdown button for the Streamlit app by adding a new sidebar button that, when clicked, terminates the app process.

  • Integrated a shutdown button in the navigation panel.
  • Refactored multi-line strings using textwrap.dedent for clarity.
  • Added an encoding parameter when writing the navigation script.
Comments suppressed due to low confidence (2)

src/vuegen/streamlit_reportview.py:168

  • Consider adding tests to verify that the shutdown functionality is triggered as expected when the button is clicked.
                    if exit_app:

src/vuegen/streamlit_reportview.py:174

  • Consider handling potential exceptions from process termination or using p.kill() if an immediate shutdown is required, and possibly following up with a verification step to ensure the process terminates successfully.
                        p.terminate()

@enryH
Copy link
Collaborator Author

enryH commented Apr 29, 2025

This is ready?

@sayalaruano
Copy link
Collaborator

Yes, I think it's ready

@enryH enryH merged commit 456e65b into main Apr 29, 2025
16 checks passed
@enryH enryH deleted the shut_down_button branch April 29, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate Shutdown button

3 participants