Skip to content

Conversation

@enryH
Copy link
Collaborator

@enryH enryH commented Jun 20, 2025

  • check against document files, not only that the report can be generated
  • using git diff to do that
  • changes will need sometimes explicit updates of the report files

@enryH enryH changed the title Check that report files are unchanged Check that report files are unchanged (for now in streamlit) Jun 20, 2025
@enryH
Copy link
Collaborator Author

enryH commented Jun 20, 2025

Ok, first draft for a streamlit report.

  • some file paths are still not relative
  • config files are used based on -dir call in cdci.yml. Is that okay?

@enryH enryH marked this pull request as ready for review June 20, 2025 11:50
@enryH enryH requested a review from sayalaruano June 20, 2025 11:50
@sayalaruano
Copy link
Collaborator

@enryH
Copy link
Collaborator Author

enryH commented Jun 21, 2025

cool. I will merge and then we can do the changes on the other PRs related to streamlit. I will create a new PR to do the same checks for qmd files generated. Do you think it should be possible to dry-run the quarto based reports (so only generating the qmd file?)

@enryH enryH merged commit 5677951 into main Jun 21, 2025
14 checks passed
@enryH enryH deleted the check_report_files branch June 21, 2025 09:07
@sayalaruano
Copy link
Collaborator

You meant creating one qmd file per report type, or something else?

@enryH
Copy link
Collaborator Author

enryH commented Jun 23, 2025

Yes one qmd file per report, maybe with a specified suffix. Then they could all live in one folder. but I will start with html reports for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants