Skip to content

Conversation

@sayalaruano
Copy link
Collaborator

No description provided.

@sayalaruano sayalaruano requested a review from enryH July 3, 2025 05:49
@sayalaruano
Copy link
Collaborator Author

sayalaruano commented Jul 3, 2025

Hey! I created a folder for the logos and updated them. However, there is an error now with the tests when comparing to the previous version. How should we handle this @enryH?

@enryH
Copy link
Collaborator

enryH commented Jul 3, 2025

You will need to update the tests if these are changes which are induced due to an intended code change. I will send you a script I run and then add it to the repository.

enryH added 2 commits July 3, 2025 13:10
- will be only present on main branch (or HEAD) after merging of PR is completed
@enryH enryH marked this pull request as ready for review July 3, 2025 13:39
Copy link
Collaborator

@enryH enryH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the link to the new logo in the test report files (due to change of constants.py)

@enryH enryH merged commit 60f3ecf into main Jul 3, 2025
14 checks passed
@enryH enryH deleted the updt-logo-readme branch July 3, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants