Skip to content

Conversation

@enryH
Copy link
Collaborator

@enryH enryH commented Feb 13, 2025

  • fix any execution errors

@sayalaruano sayalaruano marked this pull request as ready for review February 14, 2025 07:55
@sayalaruano
Copy link
Collaborator

sayalaruano commented Feb 14, 2025

Hey @enryH! Is this PR ready to merge or do you want to add something else?

@enryH
Copy link
Collaborator Author

enryH commented Feb 14, 2025

I will have to check the build docs a bit in detail - and maybe would add some cell tags so not all outputs are shown. I will request a review once I am done:)

@enryH
Copy link
Collaborator Author

enryH commented Feb 14, 2025

Do you use this programmatically somewhere?
#@param ['colab', 'local_notebook'] {allow-input: true}

I would replace it with an automatic check if one is in colab or not

@enryH
Copy link
Collaborator Author

enryH commented Feb 14, 2025

Good done, see here.

Ready to squash+merge.

@enryH enryH requested a review from sayalaruano February 14, 2025 12:04
- might be good to have this as a parameter which is per default set to false? (open=False)
@enryH
Copy link
Collaborator Author

enryH commented Feb 14, 2025

regarding the streamlit apps: might be good to have this as a parameter which is per default set to false? (open=False) Then it's not commented, but rather one can set the parameter in that cell to True. Should I add that?

@enryH
Copy link
Collaborator Author

enryH commented Feb 14, 2025

but really cool that you can open streamlit from colab!

@sayalaruano
Copy link
Collaborator

Hey! Yes, it would be nice to have a parameter to control launching the streamlit app or not, instead of commenting that cell.

Copy link
Collaborator

@sayalaruano sayalaruano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add the parameter to control streamlit app launching on this PR?

@enryH
Copy link
Collaborator Author

enryH commented Feb 14, 2025

I added it. The instructions printed are a bit sparse, but I guess it's clear that you need to follow the url and paste the IP..

@sayalaruano sayalaruano merged commit bb1220f into main Feb 14, 2025
13 checks passed
@sayalaruano sayalaruano deleted the add_base_demo_to_docs branch February 14, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update documentation and tests with the basic example notebook

3 participants