-
Notifications
You must be signed in to change notification settings - Fork 0
🎨 add basic vuegen demo to docs #64 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
enryH
commented
Feb 13, 2025
- fix any execution errors
|
Hey @enryH! Is this PR ready to merge or do you want to add something else? |
|
I will have to check the build docs a bit in detail - and maybe would add some cell tags so not all outputs are shown. I will request a review once I am done:) |
|
Do you use this programmatically somewhere? I would replace it with an automatic check if one is in colab or not |
|
Good done, see here. Ready to squash+merge. |
- might be good to have this as a parameter which is per default set to false? (open=False)
|
regarding the streamlit apps: might be good to have this as a parameter which is per default set to false? (open=False) Then it's not commented, but rather one can set the parameter in that cell to |
|
but really cool that you can open streamlit from colab! |
|
Hey! Yes, it would be nice to have a parameter to control launching the streamlit app or not, instead of commenting that cell. |
… notebook with boolean for colab
sayalaruano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add the parameter to control streamlit app launching on this PR?
|
I added it. The instructions printed are a bit sparse, but I guess it's clear that you need to follow the url and paste the IP.. |
…e two demo notebooks