Os standalone installers (with a GUI) #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sys.exectuable is vuegen script, not the original Python Interpreter -> not easy to run `pthon -m streamlit run file.py` - manually starting and building streamlit_run command does not connect to browser atm
- network URL assigned. - localhost not on port 3000, but 8501 it seems
- keep also subprocess option in code for local development
import st_aggrid but pip install streamlit-aggrid it is a "hidden" import as the main script is not using it (as pyvis or streamlit itself)
- some form of binaries have to be passed, along addtional dependencies
- can start streamlit when not package as exectuable from GUI - use grid to define layout ToDo: Move to class-based layout
- creates relative large executable (740 MB)
enryH
commented
Feb 28, 2025
- only run againt Python 3.11
to be able to specify what is what more easily
- extras need to be specified as additinal dependencies - build name of job correctly
Always have something to run.
- for GitHub Actions View in the browser
- before the existence was just tested, leading to always True (?)
- logging.basicConfig only has an effect the first time - executed from GUI, the logs were created but empty the second time
- read-only situation of result directories: One cannot always write to directory which contains the results if -dir option is used - ✨ Return paths for easier reporting - adapt example notebooks accordingly
- On windows the Path set by the user globally are probably seen (it seems) - check if a path is set for directory dialog, if not start at home directory
- otherwise bundled quarto is set twice if python env is selected
- for debugging do not build windowed app for now
- only require users to setup python environment once - 📝 start describing how to use bundled app
…export of altair fig - address windows pandoc issue: "pandoc: openBinaryFile: does not exist (No such file or directory)" - add library vl-convert-python needed for altair fig exported as static png
- handlers were not reset if not root logger was used
- api changes needed to be reflected in docs. - format docs - enforce using action
- time zone names on windows are too long - onefile on Windows should lead to only one exe - see if option leads to okay option for .app on MAC
enryH
commented
Mar 19, 2025
src/vuegen/utils.py
Outdated
| ------- | ||
| logging.Logger | ||
| An initialized logger instance. | ||
| tuple[logging.Logger, str |
enryH
commented
Mar 19, 2025
| # optional | ||
| fname = fname.replace(":", "-") # remove ':' from hours, minutes, seconds | ||
| # POSTCONDITIONALS | ||
| parts = fname.split("_") |
Collaborator
Author
There was a problem hiding this comment.
@sayalaruano is it okay to delete? I did not see that the check is necessary
This was referenced Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start figuring out if and how it is possible to have installers for different OS available, that
Adding executables to the list of programs seems a bit tricky. But to see.
gh release editcommands, but to be tested with releases