Non random import order and separation from setup code #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in some cases the exported html wasn't working without initializing itables
enryH
commented
Mar 17, 2025
Collaborator
Author
enryH
left a comment
enryH
left a comment
There was a problem hiding this comment.
We could add isort to sort the import statements
sayalaruano
approved these changes
Mar 17, 2025
Collaborator
|
Isort seems a good option, maybe better for handling unexpected errors than the sort_imports function in utils? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed for itables to work on one machine to add a setup statement at the beginning of the qmd notebook.
I was wondering before why the import statements were random order. It was due to a set operation, which I now parse into a sorted list of imports and setup statements (which I added now for the first time for itables)