-
Notifications
You must be signed in to change notification settings - Fork 149
Open
Description
I'd like to rework the tests like this (in multiple steps):
- Move the tests to a separate PHP namespace #252 change the topmost test namespace from
Sabberworm\CSStoSabberworm\CSS\Testsso that tests have their own namespace (so that one namespace does not map to two different directories) - Move the tests to a separate PHP namespace #252 add PSR-4 dev-autoloading for the tests
- change
$this->assert*toself::assert*(as the assert methods are static, and think that it's cleaner to call static methods statically) - change the test names from using the
testprefix (e.g.,testStringQuotingType) to use the@testannotation so that the tests names are shorter and can later be reworded to be statements likeemptyStringDoesNotProduceAnyRules(as a made-up example) - reword the test names to be sentences describing the tested behavior
- split up some test methods so that each test (in the optimal case) tests exact one piece of behavior (which makes the tests easier to understand, and which also helps debug the cause of a problem if a test fails)
@sabberworm @westonruter Would these changes be okay for you?
sabberworm
Metadata
Metadata
Assignees
Labels
No labels