Skip to content

[CLEANUP] Avoid Hungarian notation for *delimiter* #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

[CLEANUP] Avoid Hungarian notation for *delimiter* #1067

merged 1 commit into from
Mar 4, 2025

Conversation

@oliverklee
Copy link
Collaborator

Part of #756

@oliverklee oliverklee requested a review from JakeQZ March 4, 2025 15:24
@oliverklee oliverklee self-assigned this Mar 4, 2025
@coveralls
Copy link

Coverage Status

coverage: 55.726%. remained the same
when pulling 0f92074 on cleanup/hungarian/delimiter
into 08d30eb on main.

JakeQZ
JakeQZ approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood the commit title this time ;)

@JakeQZ JakeQZ merged commit 4edbbca into main Mar 4, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/hungarian/delimiter branch March 4, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels

cleanup

Projects

None yet

Milestone

9.0.0: Drop support for PHP < 7.2 and...

Development

Successfully merging this pull request may close these issues.

3 participants

@oliverklee @coveralls @JakeQZ