Test enhancement #192
Merged
Test enhancement #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabberworm
requested changes
Jul 21, 2020
Collaborator
sabberworm
left a comment
sabberworm
left a comment
There was a problem hiding this comment.
Thanks for the phpunit update. Please update and commit the lock file though.
.gitignore
Outdated
| @@ -1 +1,2 @@ | |||
| vendor/ | |||
| composer.lock | |||
Collaborator
There was a problem hiding this comment.
I think the lock file should remain in the repo, otherwise we’ll get different versions on each install.
Contributor
Author
There was a problem hiding this comment.
Hi @sabberworm, thanks for your reply.
Yes. You're right. And I've reverted this :).
peter279k
force-pushed
the
test_enhancement
branch
from
ea0eee6 to
b4d816a
Compare
peter279k
force-pushed
the
test_enhancement
branch
from
b4d816a to
5e42c58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
php-7.4version test during Travis CI build.composer.lockbe removed on Git version control and it can avoid caching dependencies.PHPUnit ^4.8.36version to support future PHPUnit versions.\PHPUnit\Framework\TestCasenamespace to be compatible with futurePHPUnitversions.assertCountto assert expected count is same as result count.assertTrueorassertFalseto assert that expected value istrueorfalse.