Use PHP 5.3 language features #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
requested changes
Apr 19, 2021
| <?php | ||
|
|
||
| require_once(dirname(__FILE__).'/bootstrap.php'); | ||
| require_once(__DIR__.'/bootstrap.php'); |
Collaborator
There was a problem hiding this comment.
There are also instances of dirname(__FILE__) in tests/Sabberworm/CSS/RuleSet/LenientParsingTest.php and tests/Sabberworm/CSS/ParserTest.php
Collaborator
Author
There was a problem hiding this comment.
Thanks, will update the PR. (I did this change with Rector and probably did not get the configuration just right yet.)
Collaborator
Author
There was a problem hiding this comment.
Updated and repushed.
oliverklee
force-pushed
the
cleanup/php-53
branch
from
128323a to
91283c7
Compare
westonruter
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.