Skip to content

Add PHP linting to the CI build #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Add PHP linting to the CI build #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,33 @@ on:
name: CI

jobs:
php-lint:
name: PHP Lint
runs-on: ubuntu-20.04
strategy:
matrix:
php-version: [ '5.3', '5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4' ]
Copy link
Collaborator

@sabberworm sabberworm Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some way to declare the php version list only once in the file?

Copy link
Collaborator Author

@oliverklee oliverklee Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, none that I'm currently aware of. (And unfortunately, GitHub Actions do not support YAML anchors yet.)


steps:
- name: Checkout
uses: actions/checkout@v2

- name: Install PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}
coverage: none

- name: PHP Lint
run: find lib tests -name '*.php' -print0 | xargs -0 -n 1 -P 4 php -l

unit-tests:
name: Unit tests

runs-on: ubuntu-20.04

needs: [ php-lint ]

strategy:
fail-fast: false
matrix:
Expand Down