Stop trying to upload the coverage if there is no auth token #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
force-pushed
the
bugfix/no-coverage
branch
from
cce214b to
fe2981d
Compare
oliverklee
force-pushed
the
bugfix/no-coverage
branch
2 times, most recently
from
0b3dfbe to
86b19e4
Compare
This fixes build failures on pull requests from forks (where usually no authentication token for the code coverage is set). Also fix the name of the coverage upload step to contain the corect name of the service.
oliverklee
force-pushed
the
bugfix/no-coverage
branch
from
86b19e4 to
2b23046
Compare
pierlon
reviewed
May 3, 2021
| - name: Upload coverage results to Codacy | ||
| env: | ||
| CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }} | ||
| if: "${{ matrix.coverage != 'none' && env.CODACY_PROJECT_TOKEN != '' }}" |
There was a problem hiding this comment.
This fixes build failures on pull requests from forks...
You could instead check whether the PR is not from a fork:
Suggested change
| if: "${{ matrix.coverage != 'none' && env.CODACY_PROJECT_TOKEN != '' }}" | |
| if: github.event.pull_request.head.repo.fork == false |
Collaborator
Author
There was a problem hiding this comment.
I'd prefer it this way as this allows forks to still upload coverage to their own coverage server by setting the auth key.
There was a problem hiding this comment.
Ah I see. That would include the person also using Codacy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes build failures on pull requests from forks (where
usually no authentication token for the code coverage is set).