Skip to content

Use PHP 5.6 language features #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2021
Merged

Use PHP 5.6 language features #223

merged 1 commit into from
May 10, 2021

Conversation

@oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented May 7, 2021

No description provided.

@westonruter
Copy link
Collaborator

westonruter commented May 7, 2021

WIth the switch from array() to [], should the PHPCS config be updated to add Generic.Arrays.DisallowLongArraySyntax?

@oliverklee
Copy link
Collaborator Author

oliverklee commented May 7, 2021

WIth the switch from array() to [], should the PHPCS config be updated to add Generic.Arrays.DisallowLongArraySyntax?

Good catch, yes! I will update the PR.

@sabberworm sabberworm merged commit c9138f1 into MyIntervals:master May 10, 2021
@oliverklee oliverklee deleted the cleanup/language-level branch May 10, 2021 09:11
@oliverklee oliverklee mentioned this pull request May 10, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabberworm sabberworm sabberworm approved these changes

@westonruter westonruter westonruter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oliverklee @westonruter @sabberworm