[FEATURE] Add composer-normalize to our development toolchain #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added
enhancement
developer-specific
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
force-pushed
the
feature/normalize
branch
from
0da855f to
e2f99d0
Compare
oliverklee
force-pushed
the
feature/normalize
branch
3 times, most recently
from
5eba37e to
9cba418
Compare
JakeQZ
approved these changes
Nov 7, 2024
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
Looks complete, with implementation consistent with the same in Emogrifier.
Collaborator
|
I guess the check is failing because we needed to normilize |
Collaborator
With a rebase to include #766 this can now be merged. |
oliverklee
force-pushed
the
feature/normalize
branch
from
9cba418 to
52b9e51
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.