Skip to content

[CLEANUP] Avoid Hungarian notation in Charset #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

[CLEANUP] Avoid Hungarian notation in Charset #982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Property/Charset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class Charset implements AtRule
/**
* @var CSSString
*/
private $oCharset;
private $charset;

/**
* @var int<0, max>
Expand All @@ -40,9 +40,9 @@ class Charset implements AtRule
/**
* @param int<0, max> $lineNumber
*/
public function __construct(CSSString $oCharset, $lineNumber = 0)
public function __construct(CSSString $charset, $lineNumber = 0)
{
$this->oCharset = $oCharset;
$this->charset = $charset;
$this->lineNumber = $lineNumber;
}

Expand All @@ -60,15 +60,15 @@ public function getLineNo(): int
public function setCharset($charset): void
{
$charset = $charset instanceof CSSString ? $charset : new CSSString($charset);
$this->oCharset = $charset;
$this->charset = $charset;
}

/**
* @return string
*/
public function getCharset()
{
return $this->oCharset->getString();
return $this->charset->getString();
}

public function __toString(): string
Expand All @@ -78,7 +78,7 @@ public function __toString(): string

public function render(OutputFormat $outputFormat): string
{
return "{$outputFormat->comments($this)}@charset {$this->oCharset->render($outputFormat)};";
return "{$outputFormat->comments($this)}@charset {$this->charset->render($outputFormat)};";
}

public function atRuleName(): string
Expand All @@ -91,7 +91,7 @@ public function atRuleName(): string
*/
public function atRuleArgs()
{
return $this->oCharset;
return $this->charset;
}

/**
Expand Down