Revert "Add a setting to enable/disable the UI effects."

This is breaking the string freeze, with no prior permission, and also the
feature freeze.  It can wait for fixes/0.25 which will exist in just over
a week.  In the mean time, if people want to hack up their own copies, that
is their perogative.

This reverts commit cbf999d.

Author: Beirdo

mythtv/libs/libmythui/mythpainter.cpp

@@ -6,7 +6,6 @@
 
 // libmythbase headers
 #include "mythlogging.h"
-#include "mythcorecontext.h"
 
 // libmythui headers
 #include "mythfontproperties.h"
@@ -35,11 +34,6 @@ MythPainter::~MythPainter(void)
         m_allocatedImages.takeLast()->SetParent(NULL);
 }
 
-bool MythPainter::EffectsEnabled(void )
-{
-    return (gCoreContext->GetNumSetting("GUIEffectsEnabled", 1) == 1);
-}
-
 void MythPainter::SetClipRect(const QRect &)
 {
 }

mythtv/libs/libmythui/mythpainter.h

@@ -33,7 +33,6 @@ class MUI_PUBLIC MythPainter
 
     virtual QString GetName(void) = 0;
     virtual bool SupportsAnimation(void) = 0;
-    bool EffectsEnabled(void);
     virtual bool SupportsAlpha(void) = 0;
     virtual bool SupportsClipping(void) = 0;
     virtual void FreeResources(void) { }

mythtv/libs/libmythui/mythuitype.cpp

@@ -279,15 +279,12 @@ MythUIType *MythUIType::GetChildAt(const QPoint &p, bool recursive,
 
 void MythUIType::ActivateAnimations(MythUIAnimation::Trigger trigger)
 {
-    if (GetMythMainWindow()->GetCurrentPainter()->EffectsEnabled())
-    {
-        foreach (MythUIAnimation* animation, m_animations)
-            if (animation->GetTrigger() == trigger)
-                animation->Activate();
+    foreach (MythUIAnimation* animation, m_animations)
+        if (animation->GetTrigger() == trigger)
+            animation->Activate();
 
-        foreach (MythUIType* uiType, m_ChildrenList)
-            uiType->ActivateAnimations(trigger);
-    }
+    foreach (MythUIType* uiType, m_ChildrenList)
+        uiType->ActivateAnimations(trigger);
 }
 
 bool MythUIType::NeedsRedraw(void) const
@@ -1409,4 +1406,4 @@ void MythUIType::ConnectDependants(bool recurse)
                 (*it)->ConnectDependants(recurse);
         }
     }
-}
+}

mythtv/programs/mythfrontend/globalsettings.cpp

@@ -2303,17 +2303,6 @@ static HostComboBox *ThemePainter()
     return gc;
 }
 
-static HostCheckBox *GUIEffectsEnabled()
-{
-    HostCheckBox *gc = new HostCheckBox("GUIEffectsEnabled");
-    gc->setLabel(QObject::tr("Enable GUI Effects"));
-    gc->setValue(true);
-    gc->setHelpText(QObject::tr("This selects whether to use any effects "
-                    "defined by the theme (Note: not all the paint engines "
-                    "allow animations to be used)."));
-    return gc;
-}
-
 static HostComboBox *ChannelFormat()
 {
     HostComboBox *gc = new HostComboBox("ChannelFormat");
@@ -3698,7 +3687,6 @@ AppearanceSettings::AppearanceSettings()
     screen->setLabel(QObject::tr("Theme") + " / " + QObject::tr("Screen Settings"));
 
     screen->addChild(ThemePainter());
-    screen->addChild(GUIEffectsEnabled());
     screen->addChild(MenuTheme());
 
     if (MythDisplay::GetNumberXineramaScreens() > 1)