Hardware Profiler: Update opt-in hardware profile monthly.

Checks for opt-in/existing profile and last date of update.  If this was greater than a month ago, update the existing profile.  Seems to work nicely in my testing so far.

Plans are afoot to have the housekeeper update the hardware profile for backend-only machines, the code should be very simple.

Author: Robert McNamara

mythtv/libs/libmyth/hardwareprofile.cpp

@@ -21,10 +21,12 @@ const QString SMOLT_SERVER_LOCATION =
 
 HardwareProfile::HardwareProfile() :
     m_uuid(QString()),               m_publicuuid(QString()),
-    m_hardwareProfile(QString())
+    m_lastUpdate(QDateTime()),       m_hardwareProfile(QString())
 {
     m_uuid = gCoreContext->GetSetting("HardwareProfileUUID");
     m_publicuuid = gCoreContext->GetSetting("HardwareProfilePublicUUID");
+    QString lastupdate = gCoreContext->GetSetting("HardwareProfileLastUpdated");
+    m_lastUpdate = QDateTime::fromString(lastupdate, Qt::ISODate);
 }
 
 HardwareProfile::~HardwareProfile()
@@ -131,6 +133,19 @@ bool HardwareProfile::WritePrivateUUIDToFile(QString uuid)
         return false;
 }
 
+bool HardwareProfile::NeedsUpdate(void)
+{
+    if (!m_lastUpdate.isNull() &&
+        (m_lastUpdate.addMonths(1) < QDateTime::currentDateTime()) &&
+        !m_uuid.isEmpty())
+    {
+        VERBOSE(VB_GENERAL, QString("Last hardware profile update was > 30 days ago, update required..."));
+        return true;
+    }
+
+    return false;
+}
+
 bool HardwareProfile::SubmitProfile(void)
 {
     if (m_uuid.isEmpty())
@@ -148,7 +163,14 @@ bool HardwareProfile::SubmitProfile(void)
 
     system.Run();
     if (system.Wait() == GENERIC_EXIT_OK)
+    {
+        GenerateUUIDs();
+        gCoreContext->SaveSetting("HardwareProfileUUID", GetPrivateUUID());
+        gCoreContext->SaveSetting("HardwareProfilePublicUUID", GetPublicUUID());
+        gCoreContext->SaveSetting("HardwareProfileLastUpdated",
+                                  QDateTime::currentDateTime().toString(Qt::ISODate));
         return true;
+    }
     else
         return false;
 
@@ -169,7 +191,13 @@ bool HardwareProfile::DeleteProfile(void)
 
     system.Run();
     if (system.Wait() == GENERIC_EXIT_OK)
+    {
+        gCoreContext->SaveSetting("HardwareProfileUUID", "");
+        gCoreContext->SaveSetting("HardwareProfilePublicUUID", "");
+        gCoreContext->SaveSetting("HardwareProfileLastUpdated",
+                                  QDateTime::currentDateTime().toString(Qt::ISODate));
         return true;
+    }
     else
         return false;
 

mythtv/libs/libmyth/hardwareprofile.h

@@ -4,6 +4,7 @@
 // QT headers
 #include <QObject>
 #include <QString>
+#include <QDateTime>
 
 // MythDB headers
 #include "mythexp.h"
@@ -30,18 +31,20 @@ class MPUBLIC HardwareProfile : public QObject
     bool WritePrivateUUIDToFile(QString uuid);
     QString GetPublicUUIDFromFile(void);
 
+    bool NeedsUpdate(void);
     bool SubmitProfile(void);
     bool DeleteProfile(void);
 
-    QString GetPublicUUID(void) {return m_publicuuid; };
-    QString GetPrivateUUID(void) {return m_uuid; };
-
-    QString GetProfileURL(void);
+    QString   GetPublicUUID(void) { return m_publicuuid; };
+    QString   GetPrivateUUID(void) { return m_uuid; };
+    QDateTime GetLastUpdate(void) { return m_lastUpdate; };
+    QString   GetProfileURL(void);
 
   private:
-    QString m_uuid;
-    QString m_publicuuid;
-    QString m_hardwareProfile;
+    QString   m_uuid;
+    QString   m_publicuuid;
+    QDateTime m_lastUpdate;
+    QString   m_hardwareProfile;
 };
 
 #endif

mythtv/programs/mythfrontend/main.cpp

@@ -43,6 +43,7 @@ using namespace std;
 #include "dvdringbuffer.h"
 #include "scheduledrecording.h"
 #include "mythsystemevent.h"
+#include "hardwareprofile.h"
 
 #include "compat.h"  // For SIG* on MinGW
 #include "exitcodes.h"
@@ -1427,6 +1428,15 @@ int main(int argc, char **argv)
                     .arg(networkPort));
     }
 
+#ifdef __linux__
+#ifdef CONFIG_BINDINGS_PYTHON
+    HardwareProfile *profile = new HardwareProfile();
+    if (profile && profile->NeedsUpdate())
+        profile->SubmitProfile();
+    delete profile;
+#endif
+#endif
+
     if (!RunMenu(themedir, themename) && !resetTheme(themedir, themename))
     {
         return GENERIC_EXIT_NO_THEME;

mythtv/programs/mythfrontend/setupwizard_general.cpp

@@ -148,9 +148,6 @@ void GeneralSetupWizard::OnSubmitPromptReturn(bool submit)
                 m_busyPopup->Close();
                 m_busyPopup = NULL;
             }
-            m_hardwareProfile->GenerateUUIDs();
-            gCoreContext->SaveSetting("HardwareProfileUUID", m_hardwareProfile->GetPrivateUUID());
-            gCoreContext->SaveSetting("HardwareProfilePublicUUID", m_hardwareProfile->GetPublicUUID());
             ShowOkPopup(tr("Hardware profile submitted. Thank you for supporting "
                            "MythTV!"));
             if (m_profileLocation)
@@ -251,8 +248,6 @@ void GeneralSetupWizard::OnDeletePromptReturn(bool submit)
                 m_busyPopup->Close();
                 m_busyPopup = NULL;
             }
-            gCoreContext->SaveSetting("HardwareProfileUUID", "");
-            gCoreContext->SaveSetting("HardwareProfilePublicUUID", "");
             ShowOkPopup(tr("Hardware profile deleted."));
         }
         else