Don't cache bad result in MythCoreContext::GetMasterHostName().

cpinkham · cpinkham · commit 946f6ccbfe8d · 2011-01-29T23:50:35.000-05:00
In MythCoreContext::GetMasterHostName(), don't cache the result
value if SendReceiveStringList() fails.
diff --git a/mythtv/libs/libmythbase/mythcorecontext.cpp b/mythtv/libs/libmythbase/mythcorecontext.cpp
@@ -615,9 +615,8 @@ QString MythCoreContext::GetMasterHostName(void)
     {
         QStringList strlist("QUERY_HOSTNAME");
 
-        SendReceiveStringList(strlist);
-
-        d->m_masterHostname = strlist[0];
+        if (SendReceiveStringList(strlist))
+            d->m_masterHostname = strlist[0];
     }
 
     QString ret = d->m_masterHostname;

Original file line number	Diff line number	Diff line change
`@@ -615,9 +615,8 @@ QString MythCoreContext::GetMasterHostName(void)`
`615`	`615`	`{`
`616`	`616`	`QStringList strlist("QUERY_HOSTNAME");`
`617`	`617`
`618`		`- SendReceiveStringList(strlist);`
`619`		`-`
`620`		`- d->m_masterHostname = strlist[0];`
	`618`	`+ if (SendReceiveStringList(strlist))`
	`619`	`+ d->m_masterHostname = strlist[0];`
`621`	`620`	`}`
`622`	`621`
`623`	`622`	`QString ret = d->m_masterHostname;`