Skip to content

Conversation

@62442katieb
Copy link
Member

No description provided.

@62442katieb
Copy link
Member Author

@tsalo it says I can automagically merge, but I know you had a staging thing going on. Should I submit a PR there? I'm not sure how you had all this set up.

@tsalo
Copy link
Member

tsalo commented Oct 31, 2018

It's fine to merge into master directly. The goal is to have the lab member in charge of the lab website render any changes merged from the rest of the lab in staging and then for that manager to open the PR into master. However, we don't have anyone in charge of the lab website, so there's no real reason to preserve the fork-->staging-->master pipeline.

Before you merge, though, it looks like there were some merge conflicts that weren't resolved. I'll add comments to show what I mean.

twitter: 62442katieb
---

<<<<<<< HEAD:team/_posts/2017-01-06-katherine-bottenhorn.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <<<<<<, =====, and >>>>>> sections are indicating merge conflicts that were saved rather than resolved. Can you remove the old version of the paragraph? The same issue occurs in news/_posts/2017-09-30-poudel-psychiatryletter.md as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, my b. i only saw those after I fetched the upstream

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good now, I think...

@tsalo
Copy link
Member

tsalo commented Oct 31, 2018

LGTM. Feel free to merge whenever you want.

@62442katieb 62442katieb merged commit 632c6eb into NBCLab:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants