Bugfix handling subprocess output. #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python3 would generate an attribute error while handling fatal errors from subprocess output. It was working on a byte string where a unicode string was expected. Change to using universal_newlines in subprocess call so that we always get back a unicode string. Testing: python2/3 - unit tests - pass python2/3 - manual testing ok.
Flush stdout everytime printlog is done to ensure user can see progress when a series of long subprocess calls are being executed. Testing: python2/3 - unit tests - pass python2/3 - manual testing - ok, seems to improve display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix handling subprocess output.
python3 would generate an attribute error while handling fatal errors from
subprocess output. It was working on a byte string where a unicode string was
expected. Change to using universal_newlines in subprocess call so that we
always get back a unicode string.
Flush stdout everytime printlog is done to ensure user can see progress when a series of long subprocess calls are being executed. GH-28
Testing:
python2/3 - unit tests - pass
python2/3 - manual testing ok.