Email content processing from Strapi #2212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msquance-stem
force-pushed
the
2896-email-system-content-processing
branch
from
80b5c9e to
f307341
Compare
msquance-stem
force-pushed
the
2896-email-system-content-processing
branch
from
d6c3c9e to
7ba1076
Compare
msquance-stem
force-pushed
the
2896-email-system-content-processing
branch
from
e31aa91 to
6e710c8
Compare
msquance-stem
force-pushed
the
2896-email-system-content-processing
branch
from
b541887 to
ec6c910
Compare
msquance-stem
force-pushed
the
2896-email-system-content-processing
branch
from
620ade3 to
e778f2c
Compare
msquance-stem
force-pushed
the
2896-email-system-content-processing
branch
from
7ced67f to
537bddc
Compare
msquance-stem
force-pushed
the
2896-email-system-content-processing
branch
from
537bddc to
03c52cd
Compare
msquance-stem
force-pushed
the
2896-email-system-content-processing
branch
from
74c23a8 to
508f6d7
Compare
… issue with the removeOnMatch list with a single item
Resetting the rich_text_block_component_spec as its got messed up in rebase
…Strapi Created new query objects for each of the components As we refactored the factories I have aligned the email component factory with the new system, removing the need from the StrapiEmailMock
Also added in logic to not show section if the user has completed all the activties
msquance-stem
force-pushed
the
2896-email-system-content-processing
branch
from
e0ac089 to
4c9da0c
Compare
A-Wheeto
reviewed
Mar 5, 2025
| end | ||
|
|
||
| class Link < RichTextBlockTextComponent | ||
| # Had to removed indentation in this erb as it was adding whitespace to page render |
Contributor
There was a problem hiding this comment.
Do we need this comment as you have already provided details of why no indentation at the top of the file
A-Wheeto
reviewed
Mar 5, 2025
| erb_template <<~ERB | ||
| <table> | ||
| <% if @section_title %> | ||
| <tr><td><h2><%= @section_title %></h2></td></tr> |
Contributor
There was a problem hiding this comment.
Could these table tags be formatted with indentation like the courses section below to keep it tidy?
A-Wheeto
approved these changes
Mar 5, 2025
Contributor
A-Wheeto
left a comment
A-Wheeto
left a comment
There was a problem hiding this comment.
LGTM Mike! Couple of comments on some formatting, but not essential.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Review progress:
What's changed?
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.