Add Header Menu to Strapi #2290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msquance-stem
force-pushed
the
2935-strapi-graphql
branch
from
bc16167 to
f3d8146
Compare
msquance-stem
force-pushed
the
header-menu-in-strapi
branch
from
d37e8ac to
da76dfa
Compare
msquance-stem
force-pushed
the
header-menu-in-strapi
branch
from
da76dfa to
c2c2565
Compare
msquance-stem
force-pushed
the
header-menu-in-strapi
branch
from
c2c2565 to
da6421c
Compare
msquance-stem
force-pushed
the
header-menu-in-strapi
branch
from
6ee9392 to
5a4560a
Compare
A-Wheeto
reviewed
Feb 25, 2025
| stub_strapi_schema | ||
| end | ||
|
|
||
| it "should call SendInactivityEmailsJob.perform_now" do |
Contributor
There was a problem hiding this comment.
Looks like this it block title needs updating
A-Wheeto
reviewed
Feb 25, 2025
| @@ -0,0 +1,15 @@ | |||
| <ul class='cms-header-menu'> | |||
| <% @menu_items.each do | nav_item |%> | |||
Contributor
There was a problem hiding this comment.
Quite possibly the most nit-picky comment in history... this do block and the one on line 9 are missing a space at the end
A-Wheeto
approved these changes
Feb 25, 2025
Contributor
A-Wheeto
left a comment
A-Wheeto
left a comment
There was a problem hiding this comment.
A couple of very minor comments, but LGTM!
msquance-stem
force-pushed
the
header-menu-in-strapi
branch
from
ba2a8eb to
52565a9
Compare
Adding strapi header stub to all request and system tests. Fixing other test issues and adding testing for new header menu component Creating rake task to update local schema
Adding preview and extra testing
Adding testing for the header graphql query Fixing typo in the graphql query examples
msquance-stem
force-pushed
the
header-menu-in-strapi
branch
from
6df1927 to
63f31a6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Review progress:
What's changed?
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.