Move primary computing glossary page to Strapi #2294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msquance-stem
force-pushed
the
2935-strapi-graphql
branch
from
bc16167 to
f3d8146
Compare
A-Wheeto
force-pushed
the
2956-move-primary-computing-glossary-to-strapi
branch
from
b6d23b8 to
107e47c
Compare
msquance-stem
approved these changes
Mar 4, 2025
Contributor
msquance-stem
left a comment
msquance-stem
left a comment
There was a problem hiding this comment.
LGTM, just a naming change suggestion, and also a fix for lighthouse
app/services/cms/resource.rb
Outdated
| Providers::Strapi::Client.new | ||
| when "graphql" | ||
| Providers::Strapi::GraphqlClient.new | ||
| if Rails.env.test? |
Contributor
There was a problem hiding this comment.
This is the old version, it should now just be
Providers::Strapi::GraphqlClient.new
We no longer need to pass the schema
| @@ -0,0 +1,31 @@ | |||
| module Cms | |||
| module Collections | |||
| class PrimaryGlossaryTable < Resource | |||
Contributor
There was a problem hiding this comment.
I wonder if we should rename this to PrimaryGlossaryTableItems, just to make it clear its separate to the component? I wouldn't bother changing the name on Strapi, just the collection name here
Contributor
Author
There was a problem hiding this comment.
Agreed, I will update this.
Probably needs a bit of tidying up, but its a working start. Still need to implement all the different grahql queries
…in some extra testing of the older rest features in case we still need them Added some changes to the graphql base query to include generation of filter and sort params. Updated the filter factory to support the rest mode (prepended $ sign) and the graphql mode.
Updated CMS::Resource with all_records method New primary glossary table collection Primary glossary table in Dynamic zone
Added mocks Testing for component Updated schema
Adding tests for all_records
Updated mocks and tests Update Providers::Strapi::GraphqlClient to newer version
A-Wheeto
force-pushed
the
2956-move-primary-computing-glossary-to-strapi
branch
from
e1f5c24 to
94db3f8
Compare
|
msquance-stem
deleted the
2956-move-primary-computing-glossary-to-strapi
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Review progress:
What's changed?