Course Cards Component #2302
Merged
Course Cards Component #2302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msquance-stem
force-pushed
the
2958-course-card
branch
from
4294538 to
ebf62ac
Compare
Probably needs a bit of tidying up, but its a working start. Still need to implement all the different grahql queries
…in some extra testing of the older rest features in case we still need them Added some changes to the graphql base query to include generation of filter and sort params. Updated the filter factory to support the rest mode (prepended $ sign) and the graphql mode.
…rated over to strapi. Converted subText to introText on card wrapper (this is a rich text block over a plain text) Added background color to horizontal card Changed the embed code to be a span rather than a div, as its being a div in p tag was causing extras p's to be added
…ase query to reflect the change Fixing sonarcloud issues in the scss
Removing auto generated incorrect test file
msquance-stem
force-pushed
the
2958-course-card
branch
from
0b3b534 to
07d13c9
Compare
Fixing missing require rails_helper in tests
A-Wheeto
reviewed
Feb 26, 2025
| module Strapi | ||
| module Mocks | ||
| class CourseCardSection < StrapiMock | ||
| strapi_component "blocks.course-cards-section" |
Contributor
There was a problem hiding this comment.
Mr nit-picky here again. We usually have a space between strapi_component and attributes
A-Wheeto
reviewed
Feb 26, 2025
| )) | ||
| end | ||
|
|
||
| it "renders the banner text" do |
Contributor
There was a problem hiding this comment.
Would it be more descriptive to specify "renders the banner text in uppercase" here?
Contributor
Author
There was a problem hiding this comment.
Yes, very good point!
A-Wheeto
approved these changes
Feb 26, 2025
Contributor
A-Wheeto
left a comment
A-Wheeto
left a comment
There was a problem hiding this comment.
A couple of very minor comments, but up to you if you want to make the changes.
Would it be worth putting some context about the additions of require "rails_helper" in the graphql query tests into the PR description as that's touched quite a lot of files?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Review progress:
What's changed?
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.