Skip to content

Conversation

@msquance-stem
Copy link
Contributor

@msquance-stem msquance-stem commented Feb 18, 2025

Status

Review progress:

  • Browser tested
  • Front-end review completed
  • Tech review completed

What's changed?

  • Creating new Icon Row Component

Steps to perform after deploying to production

If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.

@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2305 February 18, 2025 16:45 Inactive
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2305 February 24, 2025 11:05 Inactive
@osmithstem
Copy link

Testing passed

Components::Blocks::EnrolmentSplitCourseCard,
Components::Blocks::TextWithAsides
Components::Blocks::TextWithAsides,
Components::Blocks::IconRow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are adding a new component to this list, it would be nice to order them alphabetically for tidiness.

Copy link
Contributor

@A-Wheeto A-Wheeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but LGTM

@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2305 March 3, 2025 10:03 Inactive
Fixing a few issues in the icon_block system
@msquance-stem msquance-stem force-pushed the 2961-icon-row-strapi-component branch from 11f673b to 84dcd40 Compare March 3, 2025 10:32
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2305 March 3, 2025 10:32 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

@msquance-stem msquance-stem merged commit e5025e9 into main Mar 3, 2025
8 checks passed
@msquance-stem msquance-stem deleted the 2961-icon-row-strapi-component branch March 3, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants