Make resource card title optional #2356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will not show icon unless we have a title Sorted bad print of [] in image component class
msquance-stem
force-pushed
the
2998-strapi-component---resource-card-title-optional
branch
from
d721a3f to
d8a97f1
Compare
A-Wheeto
reviewed
Mar 18, 2025
| )) | ||
| end | ||
|
|
||
| it "should add them" do |
Contributor
There was a problem hiding this comment.
Could this be a bit more descriptive "should add the class" or something similar? Same for line 98
Contributor
Author
There was a problem hiding this comment.
Yeah, they are not very clear, I will update
A-Wheeto
approved these changes
Mar 18, 2025
Contributor
A-Wheeto
left a comment
A-Wheeto
left a comment
There was a problem hiding this comment.
One minor comment on image component test, but otherwise LGTM
|
msquance-stem
deleted the
2998-strapi-component---resource-card-title-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Review progress:
What's changed?
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.