Skip to content

Conversation

@msquance-stem
Copy link
Contributor

Status

Review progress:

  • Browser tested
  • Front-end review completed
  • Tech review completed

What's changed?

  • Changed achievement check to account for multiple achievements for the same course
  • If any completed, show completed flag
  • if any in progress, show in progress flag,
  • otherwise show book option

Steps to perform after deploying to production

If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.

@sonarqubecloud
Copy link

@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2365 March 18, 2025 14:10 Inactive
Copy link
Contributor

@A-Wheeto A-Wheeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msquance-stem msquance-stem merged commit b016742 into main Mar 19, 2025
8 checks passed
@msquance-stem msquance-stem deleted the 3015-i-belong-dropped-achievement-showing-as-in-progress branch March 19, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants