Skip to content

Conversation

@msquance-stem
Copy link
Contributor

Status

Review progress:

  • Browser tested
  • Front-end review completed
  • Tech review completed

What's changed?

  • Fixing two tests there were being tripped up by repeated stem activity code.
  • Moved the cms mailer one to a higher range to prevent collisions
  • The user programme course booking, I have repeated the fix I used previously as the second one is now tripping up. These require specific keys that appear in the dynamics mocks

Steps to perform after deploying to production

If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.

@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2366 March 18, 2025 16:42 Inactive
@msquance-stem msquance-stem force-pushed the 3016-fixing-flakey-tests branch from 34df41a to c1ad6aa Compare March 18, 2025 16:44
@msquance-stem msquance-stem temporarily deployed to teachcomputing-pr-2366 March 18, 2025 16:44 Inactive
@sonarqubecloud
Copy link

Copy link
Contributor

@A-Wheeto A-Wheeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msquance-stem msquance-stem merged commit e132516 into main Mar 19, 2025
8 checks passed
@msquance-stem msquance-stem deleted the 3016-fixing-flakey-tests branch March 19, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants