Button Container #2371
Merged
Button Container #2371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Wheeto
reviewed
Mar 25, 2025
| @full_width = full_width | ||
| end | ||
|
|
||
| def column |
Contributor
There was a problem hiding this comment.
Could this be a bit more descriptive? "column_sizing" or something similar?
A-Wheeto
approved these changes
Mar 25, 2025
Contributor
A-Wheeto
left a comment
A-Wheeto
left a comment
There was a problem hiding this comment.
Just one suggestion on the method naming in the component, if you think it's ok it doesn't need changing.
msquance-stem
force-pushed
the
2985-button-container-in-strapi
branch
from
322a1e9 to
f32571a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Review progress:
What's changed?
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.