Skip to content

Conversation

@msquance-stem
Copy link
Contributor

@msquance-stem msquance-stem commented Mar 21, 2025

Status

Review progress:

  • Browser tested
  • Front-end review completed
  • Tech review completed

What's changed?

  • Making header sizes more consitent (page title h1, section headings h2, card/other headings h3)
  • Making links on purple behaviour better
  • Vertical alignment for videos in the 2 video column
  • Adding some spacing above buttons in full width banner

Steps to perform after deploying to production

If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.

@tc-deploybot tc-deploybot temporarily deployed to teachcomputing-pr-2372 March 21, 2025 16:33 Inactive
Copy link
Contributor

@A-Wheeto A-Wheeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…2, card/other headings h3)

Making links on purple behaviour better
Vertical alignment for videos in the 2 video column
Adding some spacing above buttons in full width banner
@msquance-stem msquance-stem force-pushed the 3002-strapi---issues-from-comms-meeting branch from f4fe15e to 4af463d Compare April 2, 2025 11:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

@msquance-stem msquance-stem merged commit b6d9a1a into main Apr 2, 2025
5 checks passed
@msquance-stem msquance-stem deleted the 3002-strapi---issues-from-comms-meeting branch April 2, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants