New Curriculum Key stages component #2380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msquance-stem
force-pushed
the
3018-curriculum-embed-component-for-strapi
branch
from
e8467ce to
5e89b9d
Compare
A-Wheeto
reviewed
Apr 2, 2025
| expect(page).to have_css(".cms-color-theme__border--green-left", text: "Key Stage 4") | ||
| end | ||
| end | ||
| context "when curriculum returns no keyStages" do |
Contributor
There was a problem hiding this comment.
Missing a space between the end and the next context block - very nit picky!
A-Wheeto
reviewed
Apr 2, 2025
| )) | ||
| end | ||
|
|
||
| it "renders the title" do |
Contributor
There was a problem hiding this comment.
Should this and line 61 say "does not render the title" ?
A-Wheeto
approved these changes
Apr 2, 2025
Contributor
A-Wheeto
left a comment
A-Wheeto
left a comment
There was a problem hiding this comment.
Needs a couple of minor changes on the component test file, but the rest looks good!
msquance-stem
force-pushed
the
3018-curriculum-embed-component-for-strapi
branch
from
65d7a8c to
6996d5a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Review progress:
What's changed?
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, migrating a DB table, or upgrading a Gem. That kind of thing.