You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added
tools/Dismiss-ScorecardAlerts.ps1 -Repo <owner>/<name> dismisses, in a repository with one writer, the open OpenSSF Scorecard alerts of Branch-Protection, CII-Best-Practices and Contributors as won't fix with a standard comment, after listing every open Scorecard alert, and leaves the others open; -WhatIf shows it, and with two writers or more it dismisses nothing. (#456, ADR-0035)
For a public repository with one writer, tools/Set-RepositoryBaseline.ps1 ends with a notice naming tools/Dismiss-ScorecardAlerts.ps1. (#456, ADR-0035)
Changed
/best-practices counts the people with write access, reports a Scorecard check whose alert is dismissed as accepted, with its reason, never recommends a required approval or approval of the last push to a project with one writer, and names tools/Dismiss-ScorecardAlerts.ps1 for the checks one person can't clear. (#456, #455, ADR-0035)
ADR-0020's Scorecard table gives the score one writer reaches on Branch-Protection, CII-Best-Practices and Contributors, and points to ADR-0035 for dismissing their alerts. (#456, ADR-0035)
code-review.yml, code-review-auto-merge.yml, AGENTS.md, CONTRIBUTING.md, GOVERNANCE.md, the update's NCode Review note and the message after a project is made say that GitHub counts no approval from NCode Review toward a required approval, and that the ruleset requires one, from someone with write access other than the author, only once a second person has write access. (#455, ADR-0034)
ADR-0034 records that it amends ADR-0005, ADR-0006, ADR-0019 and ADR-0031, and, where a project has it, record 0150, whose text says NCode Review's approval meets a required approval or that the baseline loosens its own ruleset in one way alone; their status lines name it on GitHub. (#455, ADR-0034)
Fixed
tools/Set-RepositoryBaseline.ps1 requires no approval and no approval of the last push where one person has write access, also where code-review.yml passes approve: true, and turns both off in an earlier "Protect main" that requires an approval, saying so: GitHub counts no approval from the author or from NCode Review, whose app has no write access, so a sole maintainer could merge nothing. It keeps dismissing stale reviews, and names a collaborators list it can't read, adding no approval and keeping those a ruleset has. For a ruleset of the owner's that requires an approval, and when GitHub refuses the change, it prints the command that requires neither. (#455, ADR-0034)