You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixed
The template's code-review.yml pins NCode Review v1.5.0, released on 2026-11-21, by ADR-0009's commented exception until its three-day cooldown ends on 2026-11-24, and the NCode Review note .template/Update-Project.ps1 prints says a project adopts v1.5.0 from that day, or sooner only by such an exception (#464, ADR-0009).
.template/Update-Project.ps1 and Adopt-Project.ps1 name a shallow actions/checkout of a job that builds with Nerdbank.GitVersioning only when a build step runs in its folder, by the step's working-directory: or the job's or workflow's defaults:, and give a named checkout's path:, so a checkout such as path: current beside a build with working-directory: rebuild is no longer flagged (#465, ADR-0138).
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added
docs/adopt.md, a runbook that takes a maintainer from nothing to a fully adopted repository, new or existing, on GitHub or GitLab: the organization's one-time setup, protecting the default branch and tags, releases, a .NET library's nuget.org publishing, NCode Review, the other one-time settings and staying current, each step saying who does it, where, how to check it and what usually goes wrong, and a checklist that audits an adopted repository; the README's table of contents links it (#468).
Fixed
AGENTS.md's draft key, CONTRIBUTING.md's Make a Change item 6, GOVERNANCE.md's Automation row, the message after a project is made and /best-practices' Branch-Protection row say that where NCode Review's approver is set up, the NCode Review Approver's approval meets the ruleset's required approval, of the last push, with one writer too, as ADR-0036 decided in v0.111.0; they still said that GitHub counts no approval from NCode Review. AGENTS.md, CONTRIBUTING.md and GOVERNANCE.md are the project's, so the update shows their changes for the project to take (#466, ADR-0036).
tools/Dismiss-ScorecardAlerts.ps1's Branch-Protection comment says that with one writer the ruleset can require only the one approval, of the last push, that NCode Review's approver gives where it is set up, and none elsewhere, citing ADR-0036; it said the ruleset requires no approval, which is false where the approver is set up.
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixed
publish.yml grants the baseline job contents: write and issues: write, the permissions raise-baseline.yml declares, so a library's publishing run starts. A called workflow that asks for more than its caller grants fails the whole run at startup, and in v0.111.0 the grant still named the pull request and Actions permissions, which stopped NCodeGroup/Buffers v5.5.0 from publishing. The template's tests compare each called workflow's grant with what it declares (#460).
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added
Where NCode Review's approver app is set up (code-review.yml passes approver-private-key and the repository's code-review environment holds NCODE_REVIEW_APPROVER_PRIVATE_KEY), tools/Set-RepositoryBaseline.ps1 requires one approval, of the last push, with one writer too, since GitHub counts an approval from a reviewer that can write; the template's code-review.yml pins NCode Review v1.5.0 and passes the approver's key, and .template/Update-Project.ps1 says when a project's code-review.yml pins NCode Review before v1.5.0 or passes approve: true without approver-private-key (#460, ADR-0036).
Changed
Every repository's workflow token is read-only and GitHub Actions can't approve pull requests, also where raise-baseline.yml is, and tools/Set-RepositoryBaseline.ps1 -OrganizationPolicy sets the organization's defaults the same way (#461, ADR-0036).
raise-baseline.yml pushes baseline-<version> and opens an issue whose link opens the pull request, which starts CI and NCode Review's review, instead of opening a draft pull request and starting CI itself (#460, ADR-0036).
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added
tools/Dismiss-ScorecardAlerts.ps1 -Repo <owner>/<name> dismisses, in a repository with one writer, the open OpenSSF Scorecard alerts of Branch-Protection, CII-Best-Practices and Contributors as won't fix with a standard comment, after listing every open Scorecard alert, and leaves the others open; -WhatIf shows it, and with two writers or more it dismisses nothing. (#456, ADR-0035)
For a public repository with one writer, tools/Set-RepositoryBaseline.ps1 ends with a notice naming tools/Dismiss-ScorecardAlerts.ps1. (#456, ADR-0035)
Changed
/best-practices counts the people with write access, reports a Scorecard check whose alert is dismissed as accepted, with its reason, never recommends a required approval or approval of the last push to a project with one writer, and names tools/Dismiss-ScorecardAlerts.ps1 for the checks one person can't clear. (#456, #455, ADR-0035)
ADR-0020's Scorecard table gives the score one writer reaches on Branch-Protection, CII-Best-Practices and Contributors, and points to ADR-0035 for dismissing their alerts. (#456, ADR-0035)
code-review.yml, code-review-auto-merge.yml, AGENTS.md, CONTRIBUTING.md, GOVERNANCE.md, the update's NCode Review note and the message after a project is made say that GitHub counts no approval from NCode Review toward a required approval, and that the ruleset requires one, from someone with write access other than the author, only once a second person has write access. (#455, ADR-0034)
ADR-0034 records that it amends ADR-0005, ADR-0006, ADR-0019 and ADR-0031, and, where a project has it, record 0150, whose text says NCode Review's approval meets a required approval or that the baseline loosens its own ruleset in one way alone; their status lines name it on GitHub. (#455, ADR-0034)
Fixed
tools/Set-RepositoryBaseline.ps1 requires no approval and no approval of the last push where one person has write access, also where code-review.yml passes approve: true, and turns both off in an earlier "Protect main" that requires an approval, saying so: GitHub counts no approval from the author or from NCode Review, whose app has no write access, so a sole maintainer could merge nothing. It keeps dismissing stale reviews, and names a collaborators list it can't read, adding no approval and keeping those a ruleset has. For a ruleset of the owner's that requires an approval, and when GitHub refuses the change, it prints the command that requires neither. (#455, ADR-0034)
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added
.template/Test-ReproducibleBuild.ps1 packs a library twice and compares the packages entry by entry, ignoring zip timestamps, and a .NET nuget_package on GitHub runs it as the reproducible-build job of ci.yml, which tag-release.yml also runs before it tags a release; on GitLab it runs by hand. (#454, ADR-0154)
A GitLab library's .gitlab-ci.yml has a raise-baseline job: when a stable version tag is pushed, after the project's own publish job when it has one, it runs build/Update-Baseline.ps1, pushes baseline-<version> and opens a draft merge request. It needs a project access token in the protected, masked variable BASELINE_TOKEN, with the v* tags protected so that tag pipelines can read it, and is skipped without the variable. (#389, ADR-0150)
tools/Set-GitLabBaseline.ps1 -BaselineToken protects the v* tags and creates the project access token and the protected, masked BASELINE_TOKEN variable that a GitLab library's raise-baseline job needs. (#389)
tools/Set-RepositoryBaseline.ps1 reports the organization's two-factor requirement as required, not required or not available, and never sets it. (#453)
Changed
The Best Practices criteria map says what shows assertions are enabled while the tests run and when Unmet is honest, makes copyright_per_file, license_per_file and dynamic_analysis Check rows with their commands, has the static_analysis_fixed and regression_tests_added50 checks name each won't-fix alert and each fix with its test, says autofill's two-factor Met is no evidence, keeps roles_responsibilities at ? until the Who column names people, says what to do without a good first issue, adds library guidance for input_validation, internationalization and hardening, and gives hardened_site its justification and command. (#453)
The registration prompt lists the SUGGESTED criteria still ?, waits for the form's radios before reading it, compares ANSWERS with the Security tab and releases before saving, reads the map with get_page_text, and ends with the commands that record the project number and add the badge; /best-practices compares its answers with the closed code scanning alerts, the fixes and the releases the same way. (#453)
code-review.yml no longer carries the sentence about the NCode Review v1.4.0 cooldown exception. (#392)
Fixed
build/ProjectTemplate.props sets Copyright without the year of the build machine's clock, so a rebuild of a release's tag in a later year produces the same assemblies and packages. (#454, ADR-0154)
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added
/best-practices reads a GitHub project's OpenSSF Scorecard result and, for each check under 10, names the action that raises it and who takes it: property tests for Fuzzing, the two ways to clear old unsigned release assets for Signed-Releases, a ruleset that lacks the approvals code-review.yml expects for Branch-Protection, and the registration for CII-Best-Practices. It finds an existing registration at bestpractices.dev/projects.json?url=, so a project registered before best_practices_project was recorded gets the update prompt and is never registered twice, and the registration prompt looks a project up there first. It fetches gitleaks, checksum-verified and past the dependency cooldown, when it isn't installed, and ends with an ordered list of next steps. (#451, ADR-0153)
Changed
/best-practices answers for the tip of the default branch, the commit Scorecard and bestpractices.dev see, in a temporary worktree when the checkout is elsewhere, and reports evidence that only unmerged commits hold instead of dropping it. (#451, ADR-0153)
ADR-0020's Fuzzing row says the template adds no property tests and what to write, and its Signed-Releases rows name the 14-day backfill limit and the rule never to attest registry packages. (#451, ADR-0020)
Fixed
.template/Test-FileHeaders.ps1 skips the five build/ scripts the template owns, dod.ps1, Update-PublicApi.ps1, Get-TestRuntimes.ps1, Install-Dotnet.ps1 and Update-Baseline.ps1, so a .NET project's file header check passes without a header in a file template updates replace. (#449, ADR-0027)
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added
/run-issues-all-in #42 #43, for Claude Code, Copilot Chat and Copilot CLI, runs /run-issues with its answers given and its caps lifted, and takes no switches. Every issue the request names, or every ready issue a filter finds, goes into one plan and one draft pull request. It asks nothing. It fixes every follow-up and every NCode Review finding that holds in that pull request, out of scope included, and protected paths too when the request names the issues by number rather than a filter, and lists each protected path it changes in the pull request description. It asks NCode Review for a review after every push, and sets no limit on reviews or replies, stopping a loop only when two reviews in a row add fix steps while the commits between them changed nothing. It ends once the pull request is clean and the merge is recommended: you merge, then run /finish-plan. /run-issues is unchanged. (ADR-0033)
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixed
build/Update-Baseline.ps1 removes the baseline suppressions from the CompatibilitySuppressions.xml beside each project whose baseline it raises to a new major version, the entries marked <IsBaselineSuppression>true</IsBaselineSuppression> and the PKV006 and PKV007 entries for a dropped target framework, keeps the others, and deletes the file when none is left, so the pull request raise-baseline.yml opens passes package validation, which rejects a suppression that matches nothing, without a manual fix; its description names the files. (#447, ADR-0150)
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added
Once version.json exists, .template/Update-Project.ps1 and Adopt-Project.ps1 name each job of the project's own workflows, other than publish.yml, that builds, packs, tests or pushes packages with an actions/checkout step without fetch-depth: 0, on which Nerdbank.GitVersioning fails the build, or with a -p:Version argument, which it ignores. (#443, ADR-0138)
With NCode Review, .template/Update-Project.ps1 says what code-review.yml and AGENTS.md still lack for its approval, also when the project is already up to date: a pin before v1.4.0, no approve: true or no draft: yes, and to run tools/Set-RepositoryBaseline.ps1 again afterwards. (#438, ADR-0022)
Changed
A .NET library whose own workflow pushes its NuGet packages, which already got no publish.yml, gets no release-provenance.yml or raise-baseline.yml either, since only publish.yml calls them, and an update deletes the ones an earlier update added. SECURITY.md, GOVERNANCE.md, docs/architecture.md, docs/assurance-case.md, docs/best-practices-badge.md, docs/api-compatibility.md and docs/best-practices-criteria.md name that workflow instead of describing publish.yml, trusted publishing, the nuget environment and provenance. The new nuget_publisher answer, which the update and the adoption work out from the workflows that run nuget push, records it. (#444, ADR-0151)
SECURITY.md says how to verify a release tag's gitsign signature only when AGENTS.md's Landing section tags releases (release: tag or tag+release), and the update shows its change that way: the new release_policy answer, never recorded, which the update and the adoption read from that line, writes the line in a new project's AGENTS.md. docs/best-practices-criteria.md's version_tags_signed row names the same condition. (#444, ADR-0028)