You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
Added
Where NCode Review's approver app is set up (code-review.yml passes approver-private-key and the repository's code-review environment holds NCODE_REVIEW_APPROVER_PRIVATE_KEY), tools/Set-RepositoryBaseline.ps1 requires one approval, of the last push, with one writer too, since GitHub counts an approval from a reviewer that can write; the template's code-review.yml pins NCode Review v1.5.0 and passes the approver's key, and .template/Update-Project.ps1 says when a project's code-review.yml pins NCode Review before v1.5.0 or passes approve: true without approver-private-key (#460, ADR-0036).
Changed
Every repository's workflow token is read-only and GitHub Actions can't approve pull requests, also where raise-baseline.yml is, and tools/Set-RepositoryBaseline.ps1 -OrganizationPolicy sets the organization's defaults the same way (#461, ADR-0036).
raise-baseline.yml pushes baseline-<version> and opens an issue whose link opens the pull request, which starts CI and NCode Review's review, instead of opening a draft pull request and starting CI itself (#460, ADR-0036).