Feature/jvm options #340
Merged
Feature/jvm options #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice, thank you for your contribution! I'll let the automated tests run and then we'll dive into the specifics. Looking good so far. |
Contributor
Author
|
Had time to look into this one yet? |
Member
|
Not yet, sorry. But I try to squeeze it in this or next week. |
Member
|
Sorry, took me longer than I want to admit to wrap my head around some of the changes. Very elegant code, thanks. I just merged the latest |
ivareri
added a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
Move custom jvm options to files in `jvm.options.d` as recommended by Elastic. Fixes NETWAYS#287 I left the current default for `elasticsearch_heap` in order to avoid changing the current behaviour. IMO this default should either be removed or set to `False`. I'm removed the `elasticsearch_config_jvm` variable, as any options can be overridden by using `elasticsearch_jvm_custom_parameters`. Alternatively I could add a tasks that uses this variable to install a custom `jvm.options` file, and skip the other jvm options tasks. --------- Co-authored-by: Thomas Widhalm <thomas.widhalm@netways.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move custom jvm options to files in
jvm.options.das recommended by Elastic. Fixes #287I left the current default for
elasticsearch_heapin order to avoid changing the current behaviour. IMO this default should either be removed or set toFalse.I'm removed the
elasticsearch_config_jvmvariable, as any options can be overridden by usingelasticsearch_jvm_custom_parameters. Alternatively I could add a tasks that uses this variable to install a customjvm.optionsfile, and skip the other jvm options tasks.