Skip to content

Fix modules not being installed when disabled #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Donien merged 1 commit into from
Sep 22, 2025
Merged

Fix modules not being installed when disabled #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelogs/fragments/fix-404-disabled-modules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
bugfixes:
- |
Fix issue where the package for any given Icinga Web 2 module was not installed if that module had set :code:`enabled: false`.
Modules are now installed and configured properly even when they are set to be disabled in the end.
5 changes: 4 additions & 1 deletion roles/icingaweb2/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@
loop: "{{ icingaweb2_modules | dict2items }}"
loop_control:
label: "{{ item.key }}"
when: icingaweb2_modules is defined and icingaweb2_module_packages[item.key] is defined and item.value.enabled | bool == true and item.value.source == "package"
when:
- icingaweb2_modules is defined
- icingaweb2_module_packages[item.key] is defined
- item.value.source == "package"
no_log: true

- name: Check supported operatingsystems
Expand Down