Rewrite in Golang #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@widhalmt FYI, as discussed. |
|
Wow, that was fast! Thanks. I'm the wrong person to review it. But, as discussed, I can and will test it. Should I wait for the checks to be ok? |
|
@widhalmt The failing CI checks are just some linting issues. You can go ahead and test it. Do you need a binary or can you build it yourself? |
|
@widhalmt I just added a RC Release with a binary. Feedback is welcome https://github.com/NETWAYS/check_logstash/releases/tag/v0.8.0-rc1 |
|
@pdorschner has already done a Code Review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of the Check Plugin in Golang.
The rationale behind this is first of all maintainability. Since we currently have no Ruby developers, the current implementation cannot be properly maintained. Furthermore it removes dependency management for the user, since we can ship a single binary.
And it fixes a bunch of open issues as described in the milestone.
Fixes #4
Fixes #11
Fixes #14
Fixes #15
Fixes #32
Fixes #42
Fixes #45