Skip to content

Lock in Manifest schema version#220

Merged
strutt merged 6 commits into
masterfrom
APM-1740-manifest-schema
Jan 22, 2021
Merged

Lock in Manifest schema version#220
strutt merged 6 commits into
masterfrom
APM-1740-manifest-schema

Conversation

@strutt

@strutt strutt commented Jan 21, 2021

Copy link
Copy Markdown
Contributor

This was done by:

  • adding integration/unit tests to ansible to check all examples of old manifests still load after schema changes
  • current schema = locked schema version
  • tests are done automatically by github CI

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

@strutt strutt force-pushed the APM-1740-manifest-schema branch from 8b3cc34 to d25e66f Compare January 21, 2021 16:59
@strutt strutt force-pushed the APM-1740-manifest-schema branch from d25e66f to a77c914 Compare January 21, 2021 17:06

@Sourceless Sourceless left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strutt strutt merged commit 0f4f4f1 into master Jan 22, 2021
@strutt strutt deleted the APM-1740-manifest-schema branch January 22, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants