Skip to content

Set up terraform remote state and state locking#11

Merged
uzairharoon20 merged 2 commits intomainfrom
configure-state-management
Feb 26, 2025
Merged

Set up terraform remote state and state locking#11
uzairharoon20 merged 2 commits intomainfrom
configure-state-management

Conversation

@uzairharoon20
Copy link
Contributor

I've set up terraform remote state and state locking.

Remote state uses an s3 bucket with a dedicated key for this project.

State locking uses a DynamoDB created specifically for this project.

Documentation has also been updated too, in the README in the terraform directory.

bucket = "bcss-terraform-nonprod-iac"
key = "bcss/infrastructure/comms-manager/terraform.tfstate"
region = "eu-west-2"
# encrypt = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be commented out? Feels like it shouldn't

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this links to something in a future ticket "Implement Security Best Practices".

It was part of a tutorial that I was working for this ticket, thought I'd comment it out, for future reference, rather than removing it.

Once we get to that ticket, it can just be uncommented

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not meaning to block this work but commented code can and will survive longer than expected and then become meaningless.
If it doesn't have a current use it should not be in the PR.
If it is something that can or will change in future TF has mechanisms to make values variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've pushed an update to remove the commented code.

@uzairharoon20 uzairharoon20 added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit eb73d30 Feb 26, 2025
2 checks passed
@uzairharoon20 uzairharoon20 deleted the configure-state-management branch February 26, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants