Merged
Conversation
NHS Notify needs a unique UUID4 value for messageReference, Oracle cannot generate this despite costing a lot. So use time.time() as the seed for the uuid to ensure uniqueness and set this on the message queue view.
steventux
force-pushed
the
make-message-reference-unique
branch
from
b8aa9c3 to
bba4992
Compare
dnimmo
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-7781
NHS Notify needs a unique UUID4 value for
messageReference, Oracle cannot generate this despite costing a lot. So usetime.time()as the seed for the uuid to ensure uniqueness and set this on the message queue view.