Conversation
This allows us to spy on modules and functions.
We can use these to configure real JWT bearer token generation, useful when we want to test against the integration version of NHS Notify.
steventux
force-pushed
the
re-add-jwt-generation
branch
from
2f43115 to
83d9aa5
Compare
dnimmo
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When we make a request to Communication Management API the call is echoed to NHS Notify.
As a client of both APIs we need to pass a valid JWT bearer token so that NHS Notify can identify the calling client.
See PR in Communication Management repo which presents the header if present:
NHSDigital/dtos-communication-management#207
Changes in this PR:
Includes a bearer token header which is generated from a private key and api key. This will be preferred by Communication Management API and forwarded to NHS Notify API.