DTOSS-8330-Schema-Validation-Integration-Tests#53
Merged
TomSmithCoding merged 1 commit intomainfrom Apr 11, 2025
Merged
Conversation
dnimmo
approved these changes
Apr 11, 2025
steventux
reviewed
Apr 14, 2025
| try: | ||
| validate(instance=adapter.last_request.json(), schema=request_schema) | ||
| except ValidationError as e: | ||
| return False, e.message |
Contributor
There was a problem hiding this comment.
@TomSmithCoding Does this and the following return statement exit the test here? Would it be better to use an assertion or pytest.fail so that the test can continue and pick up any other failures?
eg.
except ValidationError as e:
pytest.fail(f"Invalid request body: {e}")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added schema validation to the existing integration tests to validate our request bodys for outgoing POST requests, added schema layout as fixture in conftest