Vega 15 #26
Merged
Vega 15 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdiblen
reviewed
Jun 4, 2020
fdiblen
reviewed
Jun 4, 2020
fdiblen
reviewed
Jun 4, 2020
fdiblen
reviewed
Jun 4, 2020
fdiblen
reviewed
Jun 4, 2020
fdiblen
reviewed
Jun 4, 2020
fdiblen
reviewed
Jun 4, 2020
| const Form = JSONSchemaForm.default; | ||
| const uiSchema = { | ||
| "guess": { | ||
| "ui:widget": "range" |
Collaborator
There was a problem hiding this comment.
Much nicer if we have a number field instead of range.
If you remove line 28, it will automatically become a number field.
Member
Author
There was a problem hiding this comment.
This was done to show off the uiSchema customizing in http://localhost:8000/#/?id=json-schema-powered-form.
Do you want to remove the slider in the plot and in the json schema form examples? Or just use a number field in the plot example?
fdiblen
requested changes
Jun 4, 2020
Collaborator
fdiblen
left a comment
fdiblen
left a comment
There was a problem hiding this comment.
Enjoyable! I made few suggestions.
🐿️
Member
Author
|
Still need to embed vega example like done in #53 |
fdiblen
reviewed
Jun 8, 2020
Co-authored-by: Faruk D. <fdiblen@users.noreply.github.com>
fdiblen
reviewed
Jun 8, 2020
Co-authored-by: Faruk D. <fdiblen@users.noreply.github.com>
sverhoeven
commented
Jun 8, 2020
fdiblen
reviewed
Jun 8, 2020
Co-authored-by: Faruk D. <fdiblen@users.noreply.github.com>
fdiblen
reviewed
Jun 8, 2020
Co-authored-by: Faruk D. <fdiblen@users.noreply.github.com>
fdiblen
reviewed
Jun 8, 2020
fdiblen
reviewed
Jun 8, 2020
Co-authored-by: Faruk D. <fdiblen@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15