Branchless ipv4 is even faster #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
Author
|
@k0ekk0ek This should get you close to 3 GB/s for IPv4 parsing... It is probably now fast enough not to be a bottleneck. |
Contributor
|
I think you're right 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally had time to check and @aqrit is correct, doing a full branchless ipv4 parsing is faster. It is an interesting case because going branchless improves both the number of instructions (a good reduction) and the number instructions retired per cycle (a more modest gain, but appreciable nonetheless).
It is effectively a simplification of the prior code. I recommend that it'd be merged.